[PyGreSQL] [patch] relinquish GIL while connecting to database
Peter Schuller
peter.schuller at infidyne.com
Tue Sep 23 11:02:00 EDT 2008
Hello,
> > I'll check that in today if nobody protests.
>
> Ok, it's in now. Peter, can you check whether the changes
> http://www.pygresql.org/cvsweb.cgi/pygresql/module/pgmodule.c?r1=1.79&r2=1.80
> are ok? Unfortunately, we have no configure script, so it's difficult to
> check things like the PG major version in compilation conditions. As a
> workaound, I'm checking against a constant that is new in PG 8.0.
I can confirm that it has the expected effect of disabling the
relinquishing on the legacy sarge installation.
My one input is that depending on KRB4/KRB5 being defined requires
that "postgres.h" is included from the server headers; and it is not
immediately clear to me that it is guaranteed/obvoius that pg_config.h
(or whever it's being picked up) is going to be included indirectly as
a result of this.
To be extra safe, one could remove the KRB4/KRB5 test and just assume
it's dangerous on such old legacy installations.
--
/ Peter Schuller
PGP userID: 0xE9758B7D or 'Peter Schuller <peter.schuller at infidyne.com>'
Key retrieval: Send an E-Mail to getpgpkey at scode.org
E-Mail: peter.schuller at infidyne.com Web: http://www.scode.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://mailman.vex.net/pipermail/pygresql/attachments/20080923/609618cd/attachment.pgp
More information about the PyGreSQL
mailing list