[PyGreSQL] Re: DictCursor support for 3.8.1

[Simon Pamies]

D'Arcy J.M. Cain wrote:
> On Mon, 18 Sep 2006 11:53:00 +0200
> Simon Pamies <s.pamies at banality.de> wrote:
>> I just downloaded PyGreSQL 3.8.1 and noticed that there is no dict
>> cursor support included. Also the close method on the pgdbCursor class
>> is missing.
>>
> Looks fine.  However, your patch as delivered mixes spaces and tabs.

Had strange problems with python whining when I changed some lines
there, so I retabbed it using vim retab function. Then it worked.

  I
> have attached your patch with this fixed and otherwise unchanged.  In
> general patches should be attached rather than referenced so that they
> may be archived in this list.

Ok - didn't know that this list accepts attachments - will do in future :-)


> I also see that you are overwriting the close method with a do-nothing
> method.  Was this a mistake?

Yep - this was a mistake - had problems with the close method. I removed
it and it is running fine.

Simon Pamies