[PyGreSQL] suggested PyGreSQL setup.py change

Christoph Zwerschke cito at online.de
Sun Feb 12 14:45:40 EST 2006


Lance E Sloan wrote:
> I suggest making a small change to "setup.py" to help remove some 
> confusion.  What you have now:
> 
>  def getconfig(s):
>          f = os.popen("pg_config --%s"% (s))
>          x = f.readline().strip()
>          f.close()
>          return x
> 
> My suggested change:
> 
>  def getconfig(s):
>          f = os.popen("pg_config --%s"% (s))
>          x = f.readline().strip()
>          status = f.close()
>          if ( status != None ):
>                  raise "\n\n** There was a problem running pg_config.
>                  Check that it is in your PATH. **\n"
>          else:
>                  return x

Thanks for the suggestion. I have incorporated it similarly in the 
improved setup.py script.

-- Christoph


More information about the PyGreSQL mailing list